Fix S6964 FP: Properties with default values #9348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/fix-S6964-FP-default-property-value
branch
from
03c3486 to
124a3dd
Compare
| private static bool HasDefaultValue(SyntaxNode node) => node switch | ||
| { | ||
| ParameterSyntax { Default: not null } => true, | ||
| PropertyDeclarationSyntax { Initializer: not null } property => property.Parent.ParameterList() is null, |
There was a problem hiding this comment.
Why property.Parent.ParameterList() is null? How are property initializers not relevant if there is a primary constructor?
| @@ -144,4 +146,11 @@ type switch | |||
|
|
|||
| private static bool HasValidateNeverAttribute(ISymbol symbol) => | |||
| symbol.HasAttribute(KnownType.Microsoft_AspNetCore_Mvc_ModelBinding_Validation_ValidateNeverAttribute); | |||
|
|
|||
| private static bool HasDefaultValue(SyntaxNode node) => node switch | |||
There was a problem hiding this comment.
Slightly better name?
Suggested change
| private static bool HasDefaultValue(SyntaxNode node) => node switch | |
| private static bool IsInitialized(SyntaxNode node) => node switch |
|
|
martin-strecker-sonarsource
approved these changes
May 29, 2024
|
@zsolt-kolbay-sonarsource I removed my self since Martin already checked and approved! |
mary-georgiou-sonarsource
deleted the
Zsolt/fix-S6964-FP-default-property-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9331