Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all ASP.NET rules in a dedicated folder #9114

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Move all ASP.NET rules in a dedicated folder #9114

merged 4 commits into from
Apr 18, 2024

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

No description provided.

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Refactoring: Move all ASP.NET rules in a dedicated folder Refactor: Move all ASP.NET rules in a dedicated folder Apr 17, 2024
@mary-georgiou-sonarsource
Copy link
Contributor Author

@antonioaversa the primary constructor issues are FPs - see here #8436.
If you agree I'll mark them as such.

@mary-georgiou-sonarsource mary-georgiou-sonarsource mentioned this pull request Apr 18, 2024
Merged
@antonioaversa
Copy link
Contributor

@antonioaversa the primary constructor issues are FPs - see here #8436. If you agree I'll mark them as such.

I agree, I have marked them as FPs.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

antonioaversa
antonioaversa approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonioaversa antonioaversa changed the title Refactor: Move all ASP.NET rules in a dedicated folder Move all ASP.NET rules in a dedicated folder Apr 18, 2024
@antonioaversa antonioaversa merged commit 4e67e24 into master Apr 18, 2024
29 checks passed
@antonioaversa antonioaversa deleted the mary/asp-net-folder branch April 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioaversa antonioaversa antonioaversa approved these changes

Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mary-georgiou-sonarsource @antonioaversa