Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3459: add reproducer for #9106 #9112

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

CristianAmbrosini
Copy link
Contributor

Reproducer for #9106

Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the namespace for simplicity; then it's good (no further review required).

Comment on lines 206 to 214
namespace Repro9106
{
public class MyClass
{
private int _foo; // Noncompliant FP

public ref int Foo => ref _foo;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simpler:

Suggested change
namespace Repro9106
{
public class MyClass
{
private int _foo; // Noncompliant FP
public ref int Foo => ref _foo;
}
}
public class Repro_9106
{
private int _foo; // Noncompliant FP
public ref int Foo => ref _foo;
}

@CristianAmbrosini CristianAmbrosini enabled auto-merge (squash) April 17, 2024 10:40
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@CristianAmbrosini CristianAmbrosini merged commit 35e6404 into master Apr 17, 2024
27 checks passed
@CristianAmbrosini CristianAmbrosini deleted the cristian/9106_repro branch April 17, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants