Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1144 FN: Unused private getters and private setters #9098

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Fix S1144 FN: Unused private getters and private setters #9098

merged 6 commits into from
Apr 18, 2024

Conversation

CristianAmbrosini
Copy link
Contributor

Fixes #6724

@CristianAmbrosini CristianAmbrosini force-pushed the cristian/S1144-private-getset branch 2 times, most recently from 63b3a1a to df718cf Compare April 18, 2024 07:35
Tim-Pohlmann
Tim-Pohlmann requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One design decision should be changed, the rest are minor improvements only.

analyzers/src/SonarAnalyzer.CSharp/Rules/UnusedPrivateMember.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/UnusedPrivateMember.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpSymbolUsageCollector.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpSymbolUsageCollector.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/UnusedPrivateMember.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/UnusedPrivateMemberTest.Properties.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/UnusedPrivateMemberTest.Properties.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/UnusedPrivateMemberTest.Properties.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/UnusedPrivateMemberTest.Properties.cs Show resolved Hide resolved
Tim-Pohlmann
Tim-Pohlmann approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tim-Pohlmann Tim-Pohlmann enabled auto-merge (squash) April 18, 2024 15:40
@CristianAmbrosini CristianAmbrosini force-pushed the cristian/S1144-private-getset branch from 095d517 to fbf962e Compare April 18, 2024 16:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Tim-Pohlmann Tim-Pohlmann merged commit 692b1ee into master Apr 18, 2024
27 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the cristian/S1144-private-getset branch April 18, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S1144 FN: Unused private getters and private setters
2 participants
@CristianAmbrosini @Tim-Pohlmann