Fix TypeInitializationException in SymbolStartAnalysisContextWrapper

[martin-strecker-sonarsource]

Fixes AD0001
See https://cirrus-ci.com/task/5657719948967936?logs=build#L1542

CSC : error AD0001: Analyzer 
'SonarAnalyzer.Rules.CSharp.RouteTemplateShouldNotStartWithSlash' threw an exception of type 
'System.TypeInitializationException' with message 'The type initializer for 
'SonarAnalyzer.ShimLayer.AnalysisContext.SymbolStartAnalysisContextWrapper' 
threw an exception.'.

I had a UT for the fix, but it broke all the other tests because the type initializer is called only once per assembly load. I tried with AppDomains, but that didn't work. The only solution would be to isolate the test in a dedicated UT assembly, which does seem to be overkill.

[martin-strecker-sonarsource]

The Lambda() invocation throws an ArgumentException if symbolStartAnalysisContextType is null. That one caused the TypeInitializationException

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[mary-georgiou-sonarsource]

LGTM

[antonioaversa]

LGTM

I had a UT for the fix, but it broke all the other tests because the type initializer is called only once per assembly load.

Out of curiosity, could you share the UT. I would like to see how to reproduce the symbolStartAnalysisContextType being null.

[mary-georgiou-sonarsource]

@martin-strecker-sonarsource @antonioaversa is there a reason this is draft? Can we merge it?

[martin-strecker-sonarsource]

Out of curiosity, could you share the UT. I would like to see how to reproduce the symbolStartAnalysisContextType being null.

Ugly hack, which looked about like this (The SymbolStartAnalysisContextTypeName property was actually in another class because the TypeInitializer runs before the assignment is executed):

// In the UT:
SymbolStartAnalysisContextWrapper.SymbolStartAnalysisContextTypeName = "SomeNonExitingType";

// In the Wrapper
public static string SymbolStartAnalysisContextTypeName = "Microsoft.CodeAnalysis.Diagnostics.SymbolStartAnalysisContext";
// And in the Initializer:
var symbolStartAnalysisContextType = typeof(CompilationStartAnalysisContext).Assembly.GetType(SymbolStartAnalysisContextTypeName);

[antonioaversa]

Out of curiosity, could you share the UT. I would like to see how to reproduce the symbolStartAnalysisContextType being null.

Ugly hack, which looked about like this (The SymbolStartAnalysisContextTypeName property was actually in another class because the TypeInitializer runs before the assignment is executed):

// In the UT:
SymbolStartAnalysisContextWrapper.SymbolStartAnalysisContextTypeName = "SomeNonExitingType";

// In the Wrapper
public static string SymbolStartAnalysisContextTypeName = "Microsoft.CodeAnalysis.Diagnostics.SymbolStartAnalysisContext";
// And in the Initializer:
var symbolStartAnalysisContextType = typeof(CompilationStartAnalysisContext).Assembly.GetType(SymbolStartAnalysisContextTypeName);

I see, ugly indeed, I must say 😆
Thanks for clarifying!

[martin-strecker-sonarsource]

Peach validation: AD0001 is gone:
https://cirrus-ci.com/task/5582737403281408