Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S6674: Log message template should be syntactically correct #8818

Merged
merged 4 commits into from
Feb 29, 2024
Merged

New rule S6674: Log message template should be syntactically correct #8818

merged 4 commits into from
Feb 29, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

Fixes #8770

@gregory-paidis-sonarsource
Copy link
Contributor Author

@costin-zaharia-sonarsource Please take a look at the code smells.
IMO it is better to keep the entire logic in one place for the splitting part.
Also, the magic number 2 has a comment to explain what is happening.

@gregory-paidis-sonarsource gregory-paidis-sonarsource marked this pull request as ready for review February 27, 2024 17:14
costin-zaharia-sonarsource
costin-zaharia-sonarsource reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round, only unit tests

analyzers/rspec/cs/S6674.json Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/MessageTemplates/MessageTemplateAnalyzer.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/MessageTemplatesShouldBeCorrect.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/MessageTemplatesShouldBeCorrect.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/MessageTemplatesShouldBeCorrectTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/MessageTemplatesShouldBeCorrectTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/MessageTemplatesShouldBeCorrectTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/MessageTemplatesShouldBeCorrectTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/MessageTemplatesShouldBeCorrectTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/MessageTemplatesShouldBeCorrectTest.cs Show resolved Hide resolved
@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/implement-S6674 branch 3 times, most recently from 160028f to 213405d Compare February 28, 2024 16:07
@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/implement-S6674 branch 2 times, most recently from 444ef53 to 687a6f8 Compare February 28, 2024 16:49
costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit c0d6a61 into master Feb 29, 2024
25 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the greg/implement-S6674 branch February 29, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule S6674: Log message template should be syntactically correct
2 participants
@gregory-paidis-sonarsource @costin-zaharia-sonarsource