SE Loops: Addition for same sign operands #8760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
added
Type: False Negative
Tim-Pohlmann
removed
Type: False Negative
gregory-paidis-sonarsource
requested changes
Feb 15, 2024
...rc/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/ArithmeticCalculator.cs
Show resolved
Hide resolved
| BinaryOperatorKind.ExclusiveOr => NumberConstraint.From(CalculateXorMin(left, right), CalculateXorMax(left, right)), | ||
| _ => null | ||
| }; | ||
| isInLoop |
There was a problem hiding this comment.
Please write this with if (isInLoop), I don't think the ternary helps here, it's a bit too big.
| @@ -1737,6 +1742,79 @@ void ForLoop_ZeroOrOneExecutions() | |||
| } | |||
| } | |||
|
|
|||
| class LoopVariableTracking | |||
| { | |||
| void InitializationInLoop(bool condition) | |||
There was a problem hiding this comment.
Shouldn't you add any testcases for double-negative, or did I miss it?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8695