Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rule S3884 #8583

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Deprecate rule S3884 #8583

merged 1 commit into from
Jan 24, 2024

Conversation

sebastien-marichal
Copy link
Contributor

@sebastien-marichal sebastien-marichal commented Jan 23, 2024

Fixes #7960

RSPEC update has already been done in #8018, so it is basically only adding the [Obsolete] attribute.

Internal documentation about deprecation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please create a ticket about deleting the rule in the next LTS cycle.

@sebastien-marichal sebastien-marichal force-pushed the sebastien/deprecate-s3884 branch from f94226f to a4fd3b0 Compare January 24, 2024 15:10
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sebastien-marichal sebastien-marichal merged commit e0cfa81 into master Jan 24, 2024
23 checks passed
@sebastien-marichal sebastien-marichal deleted the sebastien/deprecate-s3884 branch January 24, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate rule S3884
2 participants