TestFramework: Fix coverage #8581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/3-Coverage
branch
from
50a45df to
73e1284
Compare
pavel-mikula-sonarsource
changed the base branch from
master
to
feature/TestFramework
pavel-mikula-sonarsource
force-pushed
the
Pavel/3-Coverage
branch
4 times, most recently
from
d104ba3 to
66123c8
Compare
| @@ -35,9 +35,9 @@ variables: | |||
| - name: UnitTestProjectPath | |||
| value: 'analyzers\tests\SonarAnalyzer.Test\' | |||
| - name: UnitTestResultsPath | |||
| value: '$(Agent.TempDirectory)\TestResults' | |||
| value: '$(Build.SourcesDirectory)\TestResults' | |||
There was a problem hiding this comment.
Unrelated deconfusion, to use the same directory before and after the artifact is restored
| FrameworkMoniker: 'net48' | ||
| CoverageArtifactName: 'DotnetCoverageNet48' | ||
| TestResultsArtifactName: 'DotnetTestResultsNet48' | ||
| CoverageArtifactName: 'DotNetCoverageNet48' |
There was a problem hiding this comment.
Reordered by priority
| @@ -251,7 +251,7 @@ stages: | |||
|
|
|||
| - powershell: | | |||
| cd analyzers | |||
| & dotnet test $(ProjectFilePath) -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx --results-directory $(UnitTestResultsPath) /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|.*Test',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=$(CoveragePath)/coverage.$(FrameworkMoniker).xml | |||
| & dotnet test $(ProjectFilePath) -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx --results-directory $(UnitTestResultsPath) /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter="Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|\.Test^",AltCoverPathFilter="SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration",AltCoverAttributeFilter="ExcludeFromCodeCoverage",AltCoverReport="$(CoveragePath)/coverage.$(CoverageArtifactName).xml" | |||
There was a problem hiding this comment.
This is the actual fix, .*Test was matching the .TestFramework part
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
pavel-mikula-sonarsource
force-pushed
the
Pavel/3-Coverage
branch
from
66123c8 to
c077fcb
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8542
Only the last commit
TestFramework: Fix coverageneeds a review. The rest is here to prove that covered is not 0% anymore