Fix S2583 FP: nested try catch blocks

[Tim-Pohlmann]

Fixes #8140

[zsolt-kolbay-sonarsource]

The test case for nested try-catch blocks is missing. Add it to ConditionEvaluatesToConstant.cs

// Reproducer for https://github.com/SonarSource/sonar-dotnet/issues/8484
public class Repro_8484
{
    void TestMethod()
    {
        Exception failure = null;

        try
        {
            try
            {
                var x = new object();
            }
            catch (InvalidOperationException)
            {
            }
        }
        catch (NotSupportedException exception)
        {
            failure = exception;
        }

        if (failure != null) // Compliant
        {
            Console.WriteLine("Found failures.");
        }
    }
}

[cristian-ambrosini-sonarsource]

Looks good. I like the refactoring with handlersAreExhaustive variable; removing the yield break makes the code a bit more readable

[Tim-Pohlmann]

This was actually an FN. In case of a not-NullReference-Exception, Exit would not be called.

[pavel-mikula-sonarsource]

The "because" seems wrong. And it actually turns out it is really needed there :)

[Tim-Pohlmann]

@pavel-mikula-sonarsource I have rewritten the code to be more readable and have improved precision at the same time. I will be off on holiday. If more changes are necessary, please forward the PR to @cristian-ambrosini-sonarsource.

[pavel-mikula-sonarsource]

LGTM

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud