Fix S2583 FP: Delegate unsubscription #8457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/S2583-fix-delegate-FP
branch
2 times, most recently
from
b22e397 to
a96061b
Compare
| state = state | ||
| .SetOperationValue(assignment, value) | ||
| .SetOperationValue(assignment.Target, value); | ||
| state = state.SetSymbolValue(assignment.Target.TrackedSymbol(state), value); |
There was a problem hiding this comment.
Note: the left side of the -= operator must be a field, property, or indexer. In the first two cases, the symbol is always available. For indexers, I haven't been able to create a test case where the indexer would have NotNull as a constraint.
e.g.
this[42] = delegate { };
this[42] += Callback; // this[42] doesn't have the NotNull constraint
this[42] -= Callback; So I don't check whether the tracked symbol is null.
Tim-Pohlmann
requested changes
Dec 18, 2023
.../src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/CompoundAssignment.cs
Outdated
Show resolved
Hide resolved
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/S2583-fix-delegate-FP
branch
from
a96061b to
3e6c5ce
Compare
Tim-Pohlmann
approved these changes
Dec 18, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8094