Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2589: Add FP repro for #8449 #8453

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

related to #8449

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this basically the same logic as this?

In the sense that a number is changing in the loop and we fail to track it more than N iterations?
If not, feel free to merge.

@mary-georgiou-sonarsource
Copy link
Contributor Author

Isn't this basically the same logic as this?

In the sense that a number is changing in the loop and we fail to track it more than N iterations? If not, feel free to merge.

I feel the same too but I'd like also @Tim-Pohlmann opinion.

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Tim-Pohlmann
Copy link
Contributor

@gregory-paidis-sonarsource @mary-georgiou-sonarsource in a sense and I considered recommending to close this as a duplicate. But since my SE experiment has special handling for ++ I'd like to keep this around as a separate issue.

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 0055b88 into master Dec 8, 2023
28 checks passed
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/repro-8449 branch December 8, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants