Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S6802 FP: Reduce scope to raise only within loop blocks #8387

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Fix S6802 FP: Reduce scope to raise only within loop blocks #8387

merged 4 commits into from
Nov 22, 2023

Conversation

sebastien-marichal
Copy link
Contributor

No description provided.

@sebastien-marichal sebastien-marichal added the Area: C# C# rules related issues. label Nov 21, 2023
antonioaversa
antonioaversa requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@antonioaversa antonioaversa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces a new class of false negative scenarios: see this comment.
We may decide to accept such FNs, if we can't easily do better.
If so, we should add an issue to the backlog, and add a repro to this PR.

analyzers/rspec/cs/S6802.html Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AvoidLambdaExpressionInLoopsInBlazor.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AvoidLambdaExpressionInLoopsInBlazor.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AvoidLambdaExpressionInLoopsInBlazor.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AvoidLambdaExpressionInLoopsInBlazor.razor Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/RazorClassLibProjectTest.java Show resolved Hide resolved
@sebastien-marichal sebastien-marichal mentioned this pull request Nov 22, 2023
Open
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

antonioaversa
antonioaversa approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastien-marichal sebastien-marichal merged commit d338d0d into master Nov 22, 2023
@sebastien-marichal sebastien-marichal deleted the sebastien/improve-s6802 branch November 22, 2023 14:07
@antonioaversa antonioaversa added this to the 9.14 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioaversa antonioaversa antonioaversa approved these changes

Assignees

@sebastien-marichal sebastien-marichal

Labels
Area: C# C# rules related issues.
Projects
None yet
Milestone
9.14
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastien-marichal @antonioaversa