Fix S1117 FN: support primary constructors #8251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
martin-strecker-sonarsource
requested changes
Oct 25, 2023
analyzers/src/SonarAnalyzer.CSharp/Rules/VariableShadowsField.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/VariableShadowsField.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/VariableShadowsField.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/VariableShadowsField.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/VariableShadowsField.CSharp12.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/VariableShadowsField.CSharp12.cs
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
martin-strecker-sonarsource
requested changes
Oct 25, 2023
analyzers/src/SonarAnalyzer.CSharp/Rules/VariableShadowsField.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/VariableShadowsField.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/VariableShadowsField.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/VariableShadowsField.CSharp12.cs
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S1117-FN-fix_8131
branch
from
dda3c12 to
c23a507
Compare
martin-strecker-sonarsource
approved these changes
Oct 26, 2023
| { | ||
| var members = context.ContainingSymbol.ContainingType.GetMembers(); | ||
| var primaryConstructorParameters = members.FirstOrDefault(x => x.IsPrimaryConstructor())?.GetParameters(); | ||
| var fieldsAndProperties = members.Where(x => x is IPropertySymbol or IFieldSymbol).ToList(); |
There was a problem hiding this comment.
I think we missed an SemanticModel.IsAccessible check here:
- Private fields/properties are accessible from within the declaring type but not derived types
- protected/public fields/properties are accessible from the declaring and derived types.
Just add a comment about this in #8260
This was referenced Oct 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed.
|
|
Peach validation: no changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8131