Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable code signing #8229

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Temporarily disable code signing #8229

merged 3 commits into from
Oct 19, 2023

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource commented Oct 19, 2023 •
edited
Loading

Part of #8230
The current code signing certificate has expired. Until the new one is set up this PR will disable code signing to keep the builds green.

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource requested review from a team and removed request for a team October 19, 2023 09:15
@andrei-epure-sonarsource
Copy link
Contributor

Please open an issue and assign it to the next milestone + at the top of the Kanban board for visibility, to make sure we will not forget by mistake about it.

We need to enable this back before the next release.

andrei-epure-sonarsource

This comment was marked as outdated.

Sign in to view

andrei-epure-sonarsource
andrei-epure-sonarsource requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goals: 'deploy -P release,sign'

Maven command line

sonar-dotnet/azure-pipelines.yml

Line 421 in f93cbb8

goals: 'deploy -P release,sign'

will it work? is it the same cert?

andrei-epure-sonarsource
andrei-epure-sonarsource approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit f7b9a37 into master Oct 19, 2023
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the Zsolt/disable-code-signing branch October 19, 2023 12:52
@gregory-paidis-sonarsource gregory-paidis-sonarsource mentioned this pull request Oct 31, 2023
Closed
@andrei-epure-sonarsource andrei-epure-sonarsource added this to the 9.13 milestone Nov 1, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-epure-sonarsource andrei-epure-sonarsource andrei-epure-sonarsource approved these changes

Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
None yet
Projects
None yet
Milestone
9.13
Development

Successfully merging this pull request may close these issues.
2 participants
@zsolt-kolbay-sonarsource @andrei-epure-sonarsource