Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RSPEC before 9.12 release #8161

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Update RSPEC before 9.12 release #8161

merged 1 commit into from
Oct 9, 2023

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

Fixes #8090

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

antonioaversa
antonioaversa approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The only change that requires a potential adjustment is produced by SonarSource/rspec#3150 by @pdschbrt.
However, as discussed offline with @gregory-paidis-sonarsource, despite a change of quickfix target from unknown to targeted was most likely to be limited to cfamily, the value seems to make sense for .NET too.
The right value may be partial, due to some complex cases we have with destructuring, but that may be changed in the future when and if needed.
So, all in all, this PR seems good and can be delivered to master.

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 3786561 into master Oct 9, 2023
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/update-rspec-9.12 branch October 9, 2023 14:52
@antonioaversa antonioaversa mentioned this pull request Oct 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioaversa antonioaversa antonioaversa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update RSPEC before 9.12 release
2 participants
@gregory-paidis-sonarsource @antonioaversa