Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET 8 and C# 12: fix repros and UTs for rules starting with P in SonarWay #8118

Merged
merged 8 commits into from
Oct 2, 2023
Merged

.NET 8 and C# 12: fix repros and UTs for rules starting with P in SonarWay #8118

merged 8 commits into from
Oct 2, 2023

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Oct 2, 2023 •
edited
Loading

@antonioaversa antonioaversa mentioned this pull request Oct 2, 2023
Merged
@antonioaversa antonioaversa changed the title Draft .NET 8 and C# 12: fix repros and UTs for rules starting with P in SonarWay Oct 2, 2023
@antonioaversa antonioaversa force-pushed the antonio/dotnet8-cs12-add-repros-and-uts-p-2nd branch from bd6f392 to 745fa94 Compare October 2, 2023 11:43
@antonioaversa antonioaversa force-pushed the antonio/dotnet8-cs12-add-repros-and-uts-p-2nd branch from b0fb546 to c3eb751 Compare October 2, 2023 12:16
antonioaversa
antonioaversa commented Oct 2, 2023
View reviewed changes
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ParameterValidationInYieldShouldBeWrapped.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ParametersCorrectOrder.CSharp11.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ParametersCorrectOrder.CSharp11.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ParametersCorrectOrder.CSharp12.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ParametersCorrectOrder.CSharp12.cs
@@ -91,22 +72,22 @@ public class DefaultLambdaParameters
{
void InvokedFromAnotherLambda()
{
var f1 = (int a, int b) => a + b;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8093 (comment)

These tests were not supposed to be duplicates of the ones for C# 11, but rather tests with the same structure, but having default lambda parameters set, that makes them C# 12 specific.

I have kept the C# 12 testa and added the missing default values to the lambda parameters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention the default lambda parameters in #8072 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I have added a sentence in the description of the GitHub issue.

analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ParametersCorrectOrder.cs Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@antonioaversa antonioaversa marked this pull request as ready for review October 2, 2023 14:17
cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ParametersCorrectOrder.CSharp12.cs
@@ -91,22 +72,22 @@ public class DefaultLambdaParameters
{
void InvokedFromAnotherLambda()
{
var f1 = (int a, int b) => a + b;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention the default lambda parameters in #8072 ?

@antonioaversa antonioaversa merged commit 39cec0a into master Oct 2, 2023
@antonioaversa antonioaversa deleted the antonio/dotnet8-cs12-add-repros-and-uts-p-2nd branch October 2, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource approved these changes

Assignees

@antonioaversa antonioaversa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonioaversa @cristian-ambrosini-sonarsource