Use ConvertedType instead of Type for ImplicitObjectCreation #8104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csaba-sagi-sonarsource
requested review from
cristian-ambrosini-sonarsource and
costin-zaharia-sonarsource
github-actions
bot
assigned cristian-ambrosini-sonarsource and costin-zaharia-sonarsource and unassigned csaba-sagi-sonarsource and cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource
changed the title
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned costin-zaharia-sonarsource
cristian-ambrosini-sonarsource
approved these changes
Sep 29, 2023
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned csaba-sagi-sonarsource
costin-zaharia-sonarsource
force-pushed
the
čaba/S1144-fix
branch
from
e08b257 to
da8dfe2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer for #8024
This PR also changes to check ConvertedType instead of Type for ImplicitObjectCreations.
Currently, that is also null, however, once the fix for dotnet/roslyn#70041 gets released it should stop throwing exceptions.