Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate S2589: Fix rethrow FP #7706

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

Tim-Pohlmann
Copy link
Contributor

Part 3.5 of #7646

@Tim-Pohlmann Tim-Pohlmann force-pushed the timary/S2589-implementation branch from 3fb65f3 to 2d63415 Compare July 31, 2023 06:07
Base automatically changed from timary/S2589-implementation to feature/MMF-2563 July 31, 2023 12:59
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea looks generally good

@Tim-Pohlmann Tim-Pohlmann marked this pull request as ready for review August 4, 2023 14:48
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just existing nitpicks to address (I'd normally approve it already, but I'll have to merge this one anyway)

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.16.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 7fd7985 into feature/MMF-2563 Aug 7, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Tim/S2589_Rethrow branch August 7, 2023 09:52
Tim-Pohlmann added a commit that referenced this pull request Aug 7, 2023
Tim-Pohlmann added a commit that referenced this pull request Aug 8, 2023
Tim-Pohlmann added a commit that referenced this pull request Aug 8, 2023
Tim-Pohlmann added a commit that referenced this pull request Aug 8, 2023
sebastien-marichal pushed a commit that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants