Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S6605 FP: Should not fire in expressions #7671

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Fix S6605 FP: Should not fire in expressions #7671

merged 6 commits into from
Jul 26, 2023

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes #7508

@cristian-ambrosini-sonarsource
Copy link
Contributor

We should cover the nested scenario from EF

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource deleted the Martin/S6605_Use_IsInExpressionTree branch July 26, 2023 13:49
@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Jul 26, 2023
Merged
@martin-strecker-sonarsource
Copy link
Contributor Author

Peach validation: No changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S6605 FP: Should not fire in expressions
2 participants
@martin-strecker-sonarsource @cristian-ambrosini-sonarsource