Allocations: Make IsUnchanged allocation free in the common case #7664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
martin-strecker-sonarsource
requested a review
from cristian-ambrosini-sonarsource
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned martin-strecker-sonarsource
cristian-ambrosini-sonarsource
approved these changes
Jul 25, 2023
github-actions
bot
assigned martin-strecker-sonarsource and unassigned cristian-ambrosini-sonarsource
github-actions
bot
assigned martin-strecker-sonarsource and unassigned martin-strecker-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7439
IsUnchanged allocates a delegate on each call to GetOrAdd. This can be avoided by doing a TryGet before the GetOrAdd for the common case of a cache hit. This change saves 257 MB of allocations.
Before
After
Before
After
