Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate S2583/S2589: Scaffold the rule for the new SE #7657

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Migrate S2583/S2589: Scaffold the rule for the new SE #7657

merged 5 commits into from
Jul 26, 2023

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

Related to #7646

@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as draft July 24, 2023 15:25
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the base branch from master to feature/MMF-2563 July 25, 2023 13:56
@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as ready for review July 25, 2023 15:45
@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the timary/scaffolding branch 2 times, most recently from 93cb731 to 8a067cd Compare July 26, 2023 06:32
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the base branch from feature/MMF-2563 to master July 26, 2023 07:04
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the base branch from master to feature/MMF-2563 July 26, 2023 07:05
Tim-Pohlmann
Tim-Pohlmann approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 4e3f2b5 into feature/MMF-2563 Jul 26, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the timary/scaffolding branch July 26, 2023 10:44
Tim-Pohlmann pushed a commit that referenced this pull request Aug 7, 2023
@mary-georgiou-sonarsource @Tim-Pohlmann
Migrate S2583/S2589: Scaffold the rule for the new SE (#7657)
e515642
Tim-Pohlmann pushed a commit that referenced this pull request Aug 8, 2023
@mary-georgiou-sonarsource @Tim-Pohlmann
Migrate S2583/S2589: Scaffold the rule for the new SE (#7657)
44d5f09
Tim-Pohlmann pushed a commit that referenced this pull request Aug 8, 2023
@mary-georgiou-sonarsource @Tim-Pohlmann
Migrate S2583/S2589: Scaffold the rule for the new SE (#7657)
e4282e7
Tim-Pohlmann pushed a commit that referenced this pull request Aug 8, 2023
@mary-georgiou-sonarsource @Tim-Pohlmann
Migrate S2583/S2589: Scaffold the rule for the new SE (#7657)
1c188f9
sebastien-marichal pushed a commit that referenced this pull request Aug 11, 2023
@mary-georgiou-sonarsource @sebastien-marichal
Migrate S2583/S2589: Scaffold the rule for the new SE (#7657)
1ae51e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mary-georgiou-sonarsource @Tim-Pohlmann @pavel-mikula-sonarsource