Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement S6562: Always set the DateTimeKind when creating a new DateTime object #7527

Merged
merged 12 commits into from
Jul 4, 2023
Merged

Implement S6562: Always set the DateTimeKind when creating a new DateTime object #7527

merged 12 commits into from
Jul 4, 2023

Conversation

csaba-sagi-sonarsource
Copy link
Contributor

Fixes #7081

zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource suggested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review round 1

analyzers/src/SonarAnalyzer.Common/Rules/AlwaysSetDateTimeKindBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/AlwaysSetDateTimeKindBase.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AlwaysSetDateTimeKind.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AlwaysSetDateTimeKind.cs Show resolved Hide resolved
zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource reviewed Jul 3, 2023
View reviewed changes
analyzers/tests/SonarAnalyzer.UnitTest/Rules/AlwaysSetDateTimeKindTest.cs
public void AlwaysSetDateTimeKind_VB() =>
new VerifierBuilder<VB.AlwaysSetDateTimeKind>().AddPaths("AlwaysSetDateTimeKind.vb").Verify();

#if NET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for #if NET. The test code under AlwaysSetDateTimeKind_CSharp9 works under the .NET Framework as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since C#9 is not supported in .Net Framework. We opted to run all C#9+ test cases only for .NET core

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 9 (and even newer language versions) are supported in .NET Framework. Not every language feature is available, but implicit object creations are, so I see no reasons why we should leave it out.

cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few suggestions

zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

analyzers/tests/SonarAnalyzer.UnitTest/Rules/AlwaysSetDateTimeKindTest.cs
public void AlwaysSetDateTimeKind_VB() =>
new VerifierBuilder<VB.AlwaysSetDateTimeKind>().AddPaths("AlwaysSetDateTimeKind.vb").Verify();

#if NET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 9 (and even newer language versions) are supported in .NET Framework. Not every language feature is available, but implicit object creations are, so I see no reasons why we should leave it out.

analyzers/src/SonarAnalyzer.CSharp/Rules/AlwaysSetDateTimeKind.cs Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

99.3% 99.3% Coverage
0.0% 0.0% Duplication

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource deleted the čaba/S6562 branch July 4, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource approved these changes

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule S6562: Always set the DateTimeKind when creating a new DateTime object
3 participants
@csaba-sagi-sonarsource @cristian-ambrosini-sonarsource @zsolt-kolbay-sonarsource