Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S6566: Always use DateTimeOffset instead of DateTime #7523

Merged
merged 18 commits into from
Jul 5, 2023
Merged

New rule S6566: Always use DateTimeOffset instead of DateTime #7523

merged 18 commits into from
Jul 5, 2023

Conversation

cristian-ambrosini-sonarsource
Copy link
Contributor

Fixes #7085

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource suggested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Round 1

analyzers/src/SonarAnalyzer.Common/Rules/UseDateTimeInsteadOfDateTimeOffsetBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/UseDateTimeInsteadOfDateTimeOffsetBase.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UseDateTimeInsteadOfDateTimeOffset.vb Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UseDateTimeInsteadOfDateTimeOffset.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UseDateTimeInsteadOfDateTimeOffset.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UseDateTimeInsteadOfDateTimeOffset.CSharp9.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UseDateTimeInsteadOfDateTimeOffset.CSharp9.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UseDateTimeInsteadOfDateTimeOffset.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/UseDateTimeInsteadOfDateTimeOffsetBase.cs Show resolved Hide resolved
csaba-sagi-sonarsource
csaba-sagi-sonarsource suggested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments there.

csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase once S6562 is merged to get rid of the GetType method.

zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource deleted the cristian/new-rule-S6566 branch July 5, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource approved these changes

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule S6566: Always use DateTimeOffset instead of DateTime
4 participants
@cristian-ambrosini-sonarsource @csaba-sagi-sonarsource @zsolt-kolbay-sonarsource @CristianAmbrosini