Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve S2198: message - replace silly with unnecessary #7365

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Jun 12, 2023

RSpec: SonarSource/rspec#2156

Updates from the changes of the RSpec are going to be run by @csaba-sagi-sonarsource for all C# and VB.NET rules being modified in the rspec repository in the LaYC sprint.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.9% 97.9% Coverage
0.0% 0.0% Duplication

@antonioaversa antonioaversa marked this pull request as ready for review June 13, 2023 09:20
@antonioaversa antonioaversa added this to the 9.4 milestone Jun 13, 2023
@csaba-sagi-sonarsource
Copy link
Contributor

@antonioaversa just to be specific: All C# and VB.NET rules.

Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csaba-sagi-sonarsource csaba-sagi-sonarsource merged commit ae1c21d into master Jun 13, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource deleted the Antonio/S2437-silly-unnecessary branch June 13, 2023 14:08
@antonioaversa
Copy link
Contributor Author

Change of the title for S2198 was missed in the original RSPEC PR.
A new PR, targeting 9.5 (this change is not included in #7337).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants