Improve S2437: message - replace silly with unnecessary #7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioaversa
added
Type: Improvement
Area: VB.NET
antonioaversa
force-pushed
the
Antonio/S2437-silly-unnecessary
branch
from
e978a6e to
7924b34
Compare
|
Uncovered lines (such as https://sonarcloud.io/code?id=sonaranalyzer-dotnet&pullRequest=7318&selected=sonaranalyzer-dotnet%3Aanalyzers%2Fsrc%2FSonarAnalyzer.CSharp%2FRules%2FUnnecessaryBitwiseOperationCodeFix.cs&line=36) are on existing and unmodified code, in scenarios where the codefix is applied to the wrong node type => not easy to reproduce in a test. |
cristian-ambrosini-sonarsource
suggested changes
Jun 1, 2023
| @@ -24,41 +24,41 @@ | |||
| namespace SonarAnalyzer.UnitTest.Rules | |||
| { | |||
| [TestClass] | |||
| public class SillyBitwiseOperationTest | |||
| public class UnnecessaryBitwiseOperationTest | |||
There was a problem hiding this comment.
The name of the file is still SillyBitwiseOperationTest
There was a problem hiding this comment.
Well spot, fixed!
cristian-ambrosini-sonarsource
approved these changes
Jun 1, 2023
|
SonarCloud Quality Gate failed. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSpec: SonarSource/rspec#1991