Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AD0001 on S1186: NullReferenceException for LocalFunctionStatements #7264

Merged
merged 4 commits into from
May 26, 2023
Merged

Fix AD0001 on S1186: NullReferenceException for LocalFunctionStatements #7264

merged 4 commits into from
May 26, 2023

Conversation

csaba-sagi-sonarsource
Copy link
Contributor

Fixes #7050

@csaba-sagi-sonarsource csaba-sagi-sonarsource marked this pull request as draft May 24, 2023 16:12
@csaba-sagi-sonarsource
Copy link
Contributor Author

It is reviewable, I converted it to draft to make sure it does not get merged into 9.1

costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes May 25, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@csaba-sagi-sonarsource csaba-sagi-sonarsource marked this pull request as ready for review May 26, 2023 06:12
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 2bd0eb1 into master May 26, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the čaba/S1186-fix-AD0001 branch May 26, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix AD0001 on S1186: NullReferenceException for top-level methods
3 participants
@csaba-sagi-sonarsource @costin-zaharia-sonarsource @pavel-mikula-sonarsource