Rule S6613: Implement CodeFix #7250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var diagnosticSpan = diagnostic.Location.SourceSpan; | ||
|
|
||
| if (root.FindNode(diagnosticSpan, getInnermostNodeForTie: true) is IdentifierNameSyntax identifierSyntax | ||
| && identifierSyntax is { Parent: ExpressionSyntax { Parent: InvocationExpressionSyntax invocationExpression } expression }) |
There was a problem hiding this comment.
Parent ExpressionSyntax will cover both SimpleMemberAccessExpression for simple invocations and MemberBindingExpression for conditional expressions.
cristian-ambrosini-sonarsource
requested a review
from costin-zaharia-sonarsource
analyzers/src/SonarAnalyzer.CSharp/Rules/LinkedListPropertiesInsteadOfMethodsCodeFix.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LinkedListPropertiesInsteadOfMethodsCodeFix.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LinkedListPropertiesInsteadOfMethodsCodeFix.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LinkedListPropertiesInsteadOfMethodsCodeFix.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/LinkedListPropertiesInsteadOfMethods.cs
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
requested a review
from costin-zaharia-sonarsource
costin-zaharia-sonarsource
approved these changes
May 26, 2023
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S6613-codefix
branch
from
f36fb2d to
bb730d2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed. |
pavel-mikula-sonarsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7239
RSPEC PR: SonarSource/rspec#1953