Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3900 FN: Conversion operations #7002

Merged
merged 10 commits into from
Mar 29, 2023
Merged

Fix S3900 FN: Conversion operations #7002

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a5e2f38
Add test cases
zsolt-kolbay-sonarsource Mar 29, 2023
8b9526f
Update PreProcessSimple() to support conversion operators
zsolt-kolbay-sonarsource Mar 29, 2023
623b3c3
Update ShouldExecute to support conversion syntax
zsolt-kolbay-sonarsource Mar 29, 2023
ce031c0
Fix namespace in test case
zsolt-kolbay-sonarsource Mar 29, 2023
46c25ea
Update ITs
zsolt-kolbay-sonarsource Mar 29, 2023
f8d6f10
Add more test cases
zsolt-kolbay-sonarsource Mar 29, 2023
92536e2
Review: simplify operator method
zsolt-kolbay-sonarsource Mar 29, 2023
73030fd
Review: add more test cases
zsolt-kolbay-sonarsource Mar 29, 2023
a850e07
Review: add more test cases
zsolt-kolbay-sonarsource Mar 29, 2023
d738fa2
Simplify test case
zsolt-kolbay-sonarsource Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions analyzers/its/expected/Automapper/AutoMapper--net461-S3900.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,32 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'enumerableOfProfiles' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Configuration\MapperConfigurationExpression.cs",
"region": {
"startLine": 161,
"startColumn": 37,
"endLine": 161,
"endColumn": 57
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'memberNames' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
"region": {
"startLine": 37,
"startColumn": 39,
"endLine": 37,
"endColumn": 50
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'memberOptions' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
Expand Down Expand Up @@ -613,6 +639,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'members' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
"region": {
"startLine": 170,
"startColumn": 36,
"endLine": 170,
"endColumn": 43
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'lambda' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
Expand Down Expand Up @@ -652,6 +691,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'members' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
"region": {
"startLine": 232,
"startColumn": 36,
"endLine": 232,
"endColumn": 43
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'collection' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
Expand Down Expand Up @@ -964,6 +1016,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'member' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
"region": {
"startLine": 17,
"startColumn": 131,
"endLine": 17,
"endColumn": 137
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'parameter' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
Expand Down Expand Up @@ -1029,6 +1094,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'prefixes' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",
"region": {
"startLine": 75,
"startColumn": 36,
"endLine": 75,
"endColumn": 44
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'memberName' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",
Expand Down
78 changes: 78 additions & 0 deletions analyzers/its/expected/Automapper/AutoMapper--netstandard2.0-S3900.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,32 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'enumerableOfProfiles' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Configuration\MapperConfigurationExpression.cs",
"region": {
"startLine": 161,
"startColumn": 37,
"endLine": 161,
"endColumn": 57
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'memberNames' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
"region": {
"startLine": 37,
"startColumn": 39,
"endLine": 37,
"endColumn": 50
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'memberOptions' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
Expand Down Expand Up @@ -613,6 +639,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'members' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
"region": {
"startLine": 170,
"startColumn": 36,
"endLine": 170,
"endColumn": 43
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'lambda' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
Expand Down Expand Up @@ -652,6 +691,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'members' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
"region": {
"startLine": 232,
"startColumn": 36,
"endLine": 232,
"endColumn": 43
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'collection' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
Expand Down Expand Up @@ -964,6 +1016,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'member' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
"region": {
"startLine": 17,
"startColumn": 131,
"endLine": 17,
"endColumn": 137
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'parameter' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
Expand Down Expand Up @@ -1029,6 +1094,19 @@
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'prefixes' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",
"region": {
"startLine": 75,
"startColumn": 36,
"endLine": 75,
"endColumn": 44
}
}
},
{
"id": "S3900",
"message": "Refactor this method to add validation of parameter 'memberName' before using it.",
"location": {
"uri": "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",
Expand Down
Loading