Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3900 FN: Conversion operations #7002

Merged
merged 10 commits into from
Mar 29, 2023
Merged

Fix S3900 FN: Conversion operations #7002

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a5e2f38
Add test cases
zsolt-kolbay-sonarsource Mar 29, 2023
8b9526f
Update PreProcessSimple() to support conversion operators
zsolt-kolbay-sonarsource Mar 29, 2023
623b3c3
Update ShouldExecute to support conversion syntax
zsolt-kolbay-sonarsource Mar 29, 2023
ce031c0
Fix namespace in test case
zsolt-kolbay-sonarsource Mar 29, 2023
46c25ea
Update ITs
zsolt-kolbay-sonarsource Mar 29, 2023
f8d6f10
Add more test cases
zsolt-kolbay-sonarsource Mar 29, 2023
92536e2
Review: simplify operator method
zsolt-kolbay-sonarsource Mar 29, 2023
73030fd
Review: add more test cases
zsolt-kolbay-sonarsource Mar 29, 2023
a850e07
Review: add more test cases
zsolt-kolbay-sonarsource Mar 29, 2023
d738fa2
Simplify test case
zsolt-kolbay-sonarsource Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...arAnalyzer.CSharp/SymbolicExecution/Roslyn/PublicMethodArgumentsShouldBeCheckedForNull.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,14 @@ bool NullableStateIsNotKnownForParameter(IParameterSymbol symbol) =>

private static bool IsParameterDereferenced(IOperationWrapperSonar operation) =>
operation.Parent != null
&& operation.Parent.IsAnyKind(
&& (operation.Parent.IsAnyKind(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is getting a bit difficult to read.
Maybe it would make sense to build an array of OperationKindEx, to be used in IsAnyKind?

OperationKindEx.Invocation,
OperationKindEx.FieldReference,
OperationKindEx.PropertyReference,
OperationKindEx.EventReference,
OperationKindEx.Await,
OperationKindEx.ArrayElementReference);
OperationKindEx.ArrayElementReference)
|| (operation.Parent.Kind == OperationKindEx.Conversion && IsParameterDereferenced(operation.Parent.ToSonar())));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting makes this hard to understand. Try indenting the last line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The || operator should be indented one level further w.r.t. the && operator above (to which is not aligned either, by one char).
I think however, that it would be better to simplify the structure of this logical condition, since you have different logical operators at different levels of nesting.


private sealed class ArgumentDereferenceWalker : SafeCSharpSyntaxWalker
{
Expand Down