S3655: Static properties and fields called Value #7000

antonioaversa · 2023-03-28T14:03:41Z

Part 6 of task 6 of #6794

Previous task: #6996

Fixes NullReferenceException issues encountered on peach, such as:

CSC : error AD0001: Analyzer 'SonarAnalyzer.Rules.CSharp.SymbolicExecutionRunner' threw an exception of type 'SonarAnalyzer.SymbolicExecution.SymbolicExecutionException' with message '
Error processing method: .ctor ## Method file: C:\Project\src\System.Private.ServiceModel\src\Internals\System\Runtime\IOThreadTimer.cs ## 
Method line: 55,8 ## Inner exception: System.NullReferenceException: Object reference not set to an instance of an object. ##    
at SonarAnalyzer.SymbolicExecution.Roslyn.RuleChecks.EmptyNullableValueAccessBase.PreProcessSimple(SymbolicContext context) ##    
at SonarAnalyzer.SymbolicExecution.Roslyn.SymbolicCheck.PreProcess(SymbolicContext context) ##    
at SonarAnalyzer.SymbolicExecution.Roslyn.SymbolicCheckList.InvokeChecks(SymbolicContext context, Boolean preProcess) ##    
at SonarAnalyzer.SymbolicExecution.Roslyn.RoslynSymbolicExecution.ProcessOperation(ExplodedNode node)+MoveNext() ##    
at SonarAnalyzer.SymbolicExecution.Roslyn.RoslynSymbolicExecution.Execute() ##    
at SonarAnalyzer.Rules.SymbolicExecutionRunnerBase.AnalyzeRoslyn(SonarAnalysisContext analysisContext, SonarSyntaxNodeReportingContext nodeContext, SyntaxNode body, ISymbol symbol)'. [C:\Project\src\System.Private.ServiceModel\src\System.Private.ServiceModel.csproj]

Tim-Pohlmann · 2023-03-29T15:10:26Z

.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs

+    class AClassWithStaticValueProperty
+    {
+        public AClassWithInstanceValueProperty InstanceProperty => new AClassWithInstanceValueProperty();
+
+        public static AClassWithInstanceValueProperty Value => new AClassWithInstanceValueProperty();
+    }
+
+    class AClassWithInstanceValueProperty
+    {
+        public AClassWithStaticValueProperty Value => new AClassWithStaticValueProperty();
+    }


These are not value properties.

What is your definition of "value property"? It's a property, and it's named Value, so I named it ValueProperty.

Would you prefer PropertyNamedValue instead?

Oh, this makes more sense. I was thinking of value types. I'd go with ClassWithStaticPropertyCalledValue to avoid confusion.

Tim-Pohlmann · 2023-03-29T15:10:45Z

.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs

+    class AClassWithStaticValueField
+    {
+        public AClassWithInstanceValueField InstanceField = new AClassWithInstanceValueField();
+
+        public static AClassWithInstanceValueField Value = new AClassWithInstanceValueField();
+    }
+
+    class AClassWithInstanceValueField
+    {
+        public AClassWithStaticValueField Value = new AClassWithStaticValueField();
+    }


These are not value fields.

Same as #7000 (comment), I'd say.

Tim-Pohlmann

See comments above.

Tim-Pohlmann

LGTM

Tim-Pohlmann · 2023-03-30T10:28:51Z

.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs

        }
    }

-    class AClassWithStaticValueField
+    class AClassWithStaticFieldCalledValue


Remove the A for brevity and consistency.

pavel-mikula-sonarsource

LGTM with some minor polishing

...src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/RuleChecks/EmptyNullableValueAccessBase.cs

.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs

sonarqubecloud · 2023-03-31T12:18:10Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarqubecloud · 2023-03-31T12:20:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

github-actions bot assigned antonioaversa Mar 28, 2023

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-6 branch from 79b9328 to b3538ce Compare March 28, 2023 14:26

antonioaversa changed the title ~~S3655: Static properties named Value~~ S3655: Static properties and fields named Value Mar 28, 2023

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-6 branch 2 times, most recently from 6da4d84 to a24b41c Compare March 28, 2023 15:12

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-5 branch from 5c31e36 to eb18c34 Compare March 29, 2023 07:17

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-6 branch from a24b41c to 4cf35c7 Compare March 29, 2023 13:39

antonioaversa requested a review from Tim-Pohlmann March 29, 2023 13:40

github-actions bot assigned Tim-Pohlmann and unassigned antonioaversa Mar 29, 2023

antonioaversa linked an issue Mar 29, 2023 that may be closed by this pull request

Improve S3655: Support C# 9 and C# 10 syntax #6794

Closed

6 tasks

antonioaversa mentioned this pull request Mar 29, 2023

S3655: "In" method params #7006

Merged

Tim-Pohlmann requested changes Mar 29, 2023

View reviewed changes

pavel-mikula-sonarsource unassigned Tim-Pohlmann Mar 30, 2023

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-5 branch from b5ba602 to 9480d62 Compare March 30, 2023 06:55

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-6 branch from 4cf35c7 to 008e632 Compare March 30, 2023 06:55

antonioaversa requested a review from Tim-Pohlmann March 30, 2023 07:10

github-actions bot assigned Tim-Pohlmann Mar 30, 2023

Tim-Pohlmann requested changes Mar 30, 2023

View reviewed changes

github-actions bot assigned antonioaversa and unassigned Tim-Pohlmann Mar 30, 2023

antonioaversa changed the title ~~S3655: Static properties and fields named Value~~ S3655: Static properties and fields called Value Mar 30, 2023

antonioaversa requested a review from Tim-Pohlmann March 30, 2023 09:41

github-actions bot assigned Tim-Pohlmann and unassigned antonioaversa Mar 30, 2023

Tim-Pohlmann approved these changes Mar 30, 2023

View reviewed changes

github-actions bot assigned antonioaversa and unassigned Tim-Pohlmann Mar 30, 2023

pavel-mikula-sonarsource unassigned antonioaversa Mar 30, 2023

Base automatically changed from Antonio/S3655-cs9-cs10-syntax-step6-5 to feature/SE March 30, 2023 11:55

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-6 branch from c9ab91c to 32b0d1e Compare March 30, 2023 11:59

antonioaversa marked this pull request as ready for review March 30, 2023 12:03

antonioaversa requested a review from pavel-mikula-sonarsource March 30, 2023 13:18

github-actions bot assigned pavel-mikula-sonarsource Mar 30, 2023

pavel-mikula-sonarsource approved these changes Mar 30, 2023

View reviewed changes

github-actions bot assigned antonioaversa and unassigned pavel-mikula-sonarsource Mar 30, 2023

pavel-mikula-sonarsource force-pushed the feature/SE branch from d1fa962 to d6211d9 Compare March 31, 2023 11:32

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-6 branch from 8856033 to 74ea7d5 Compare March 31, 2023 11:47

antonioaversa added 5 commits March 31, 2023 14:07

Static properties and fields named Value

115bf7d

Review 5

c7fcf3e

Review 6

5eae74f

Review 7

986d192

Review 8

2dea496

antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step6-6 branch from 74ea7d5 to 2dea496 Compare March 31, 2023 12:07

antonioaversa merged commit 12c8b40 into feature/SE Mar 31, 2023

antonioaversa deleted the Antonio/S3655-cs9-cs10-syntax-step6-6 branch March 31, 2023 12:27

pavel-mikula-sonarsource pushed a commit that referenced this pull request Apr 4, 2023

S3655: Static properties and fields called Value (#7000)

0612ef5

antonioaversa mentioned this pull request Apr 12, 2023

Fix S3900 FP: assigned parameters #7044

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

S3655: Static properties and fields called Value #7000

S3655: Static properties and fields called Value #7000

antonioaversa commented Mar 28, 2023 •

edited

Loading

Tim-Pohlmann Mar 29, 2023

antonioaversa Mar 30, 2023

Tim-Pohlmann Mar 30, 2023

Tim-Pohlmann Mar 29, 2023

antonioaversa Mar 30, 2023 •

edited

Loading

Tim-Pohlmann left a comment

Tim-Pohlmann left a comment

Tim-Pohlmann Mar 30, 2023

pavel-mikula-sonarsource left a comment

sonarqubecloud bot commented Mar 31, 2023

sonarqubecloud bot commented Mar 31, 2023

S3655: Static properties and fields called Value #7000

S3655: Static properties and fields called Value #7000

Conversation

antonioaversa commented Mar 28, 2023 • edited Loading

Tim-Pohlmann Mar 29, 2023

Choose a reason for hiding this comment

antonioaversa Mar 30, 2023

Choose a reason for hiding this comment

Tim-Pohlmann Mar 30, 2023

Choose a reason for hiding this comment

Tim-Pohlmann Mar 29, 2023

Choose a reason for hiding this comment

antonioaversa Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

Tim-Pohlmann left a comment

Choose a reason for hiding this comment

Tim-Pohlmann left a comment

Choose a reason for hiding this comment

Tim-Pohlmann Mar 30, 2023

Choose a reason for hiding this comment

pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 31, 2023

sonarqubecloud bot commented Mar 31, 2023

antonioaversa commented Mar 28, 2023 •

edited

Loading

antonioaversa Mar 30, 2023 •

edited

Loading