Fix S3655 FN: VB assignments #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
force-pushed
the
Tim/S3655-Improve-ShouldExecute
branch
from
910dee9 to
d65405f
Compare
Tim-Pohlmann
changed the title
antonioaversa
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
In itself this PR looks good to me.
However, I have stumbled upon the following false negative:
Sub Assignment()
Dim nullable As Integer? = Nothing
Dim x As Integer = nullable
End SubIt differs from your scenario because the Nothing is assigned inline, and not on a dedicated statement.
You may want to investigate and open another PR in case, further refining the detection of assignments.
Or move this one to draft and keep working on it - as you think it's best.
martin-strecker-sonarsource
requested changes
Mar 23, 2023
analyzers/src/SonarAnalyzer.VisualBasic/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Show resolved
Hide resolved
martin-strecker-sonarsource
approved these changes
Mar 23, 2023
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.vb
Outdated
Show resolved
Hide resolved
Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Mar 28, 2023
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Mar 31, 2023
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #6795