Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RSPEC #6899

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Update RSPEC #6899

merged 2 commits into from
Apr 18, 2023

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource commented Mar 10, 2023 •
edited by pavel-mikula-sonarsource
Loading

Fixes #2643

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource changed the title Update RSPEC S3900: Update RSPEC Mar 10, 2023
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource modified the milestone: 8.56 Mar 13, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource linked an issue Mar 13, 2023 that may be closed by this pull request
Fix the RSPEC Exceptions description for S3900 #2643
Closed
@pavel-mikula-sonarsource pavel-mikula-sonarsource force-pushed the feature/SE branch 2 times, most recently from eba0145 to 65df768 Compare March 20, 2023 12:52
@andrei-epure-sonarsource
Copy link
Contributor

This PR has been opened for three weeks.
If it's just an RSPEC update, why is it blocked?

@martin-strecker-sonarsource
Copy link
Contributor

It is not merged yet, because we changed the description before the implementation. I want to make sure the description matches what we ship.

Base automatically changed from feature/SE to master April 4, 2023 13:05
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Apr 14, 2023
View reviewed changes
analyzers/rspec/cs/S3900_c#.html Outdated Show resolved Hide resolved
analyzers/rspec/cs/S3900_c#.html Outdated

public void Baz(MyOtherClass other)
{
ArgumentNullException.ThrowIfNull(other);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support this now. The test is in #7039 which didn't make it to master yet. We can keep the sample.

martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are merge conflicts. You need to re-run the rspec script to update the files.

@martin-strecker-sonarsource
Copy link
Contributor

martin-strecker-sonarsource commented Apr 17, 2023 •
edited
Loading

As we are about to release, you can run the script without specifying the rule id. This pulls all the changes for all rules and it is something we need to do anyhow before release.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource changed the title S3900: Update RSPEC Update RSPEC Apr 18, 2023
martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Zsolt/S3900-spec-update branch April 18, 2023 09:02
@martin-strecker-sonarsource martin-strecker-sonarsource added this to the 8.56 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.56
Development

Successfully merging this pull request may close these issues.

Fix the RSPEC Exceptions description for S3900
3 participants
@zsolt-kolbay-sonarsource @andrei-epure-sonarsource @martin-strecker-sonarsource