SE - Nullable: Propagate constraints via nullable constructor #6856
Conversation
pavel-mikula-sonarsource
changed the base branch from
Pavel/SE/03-NewNull
to
feature/SE
| } | ||
| else if (context.State[operation.Arguments.First().ToArgument().Value] is { } value) | ||
| { | ||
| return context.State.SetOperationValue(context.Operation, value.WithConstraint(ObjectConstraint.NotNull)); |
There was a problem hiding this comment.
I don't think we need this with my work. The argument must be a non-nullable value type. Before it gets passed to the argument, there is a reference operation. We will learn on that operation the operation value "NotNull". This is more precise as it also supports e.g. new int?(true ? a : 42) as a learns "NotNull" on the reference operation and 42 learns NotNull in "ConstantCheck".
There was a problem hiding this comment.
SetOperationValue throws away whatever constraint was there from PreProcess.
We need it this way to propage other random constraints (like cryptography, or the future CBDE replacement constraints)
So those 2 do not collide (too much). In theory, the value that will arrive should already have your constraint. And in that case, WithConstraint will do NOOP as I added the check there.
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE/04-NewArg
branch
from
aba95af to
ae95ddf
Compare
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE/04-NewArg
branch
from
ae95ddf to
793e4d8
Compare
| """; | ||
| var setter = new PreProcessTestCheck(OperationKind.Literal, x => x.Operation.Instance.ConstantValue.Value is false ? x.SetOperationConstraint(TestConstraint.First) : x.State); | ||
| var validator = SETestContext.CreateCS(code, setter).Validator; | ||
| validator.ValidateTag("IsTrue", x => x.AllConstraints.Select(x => x.ToString()).OrderBy(x => x).JoinStr(", ").Should().Be("NotNull, True")); |
There was a problem hiding this comment.
I moved away from the "ToString" based testing. Instead I do something like this:
| validator.ValidateTag("IsTrue", x => x.AllConstraints.Select(x => x.ToString()).OrderBy(x => x).JoinStr(", ").Should().Be("NotNull, True")); | |
| validator.ValidateTag("IsTrue", x => x.AllConstraints.Select(x => x.Kind).Should().BeEquivalentTo(new [] { ConstraintKind.ObjectNotNull, ConstraintKind.BoolTrue })); |
There was a problem hiding this comment.
It would be nice to have x.Should().HaveConstraints(...params...) :)
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
Part of #6812
Set argument constraints for
new Nullable<int>(value)ornew Nullable<int>(42)This is a draft, the 1st
Squash 03-NewArgcommit doesn't need a review as it is in #6853