Fix S2259 FP: Should not report in switch expression after a null check #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE/FixFP
branch
from
a6e10ce to
7994c0c
Compare
martin-strecker-sonarsource
requested changes
Oct 6, 2022
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/IsPattern.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/IsPattern.cs
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.PatternMatching.cs
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.PatternMatching.cs
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.PatternMatching.cs
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.PatternMatching.cs
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.PatternMatching.cs
Outdated
Show resolved
Hide resolved
martin-strecker-sonarsource
approved these changes
Oct 10, 2022
|
|
||
| static object Tag(string name, object value) => null;"; | ||
| var validator = SETestContext.CreateCS(code, ", object arg").Validator; | ||
| validator.ValidateContainsOperation(OperationKind.TypePattern); |
There was a problem hiding this comment.
Suggested change
| validator.ValidateContainsOperation(OperationKind.TypePattern); | |
| validator.ValidateContainsOperation(expectedOperation); |
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE/FixFP
branch
from
18caeb2 to
bcbde65
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6170