-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PCI DSS 3.2 and 4.0, and ASVS 4.0 #5941
Conversation
3a68f76
to
874647f
Compare
874647f
to
9560d89
Compare
sonar-csharp-plugin/src/test/java/org/sonar/plugins/csharp/CSharpSonarRulesDefinitionTest.java
Show resolved
Hide resolved
sonar-csharp-plugin/src/test/java/org/sonar/plugins/csharp/CSharpSonarRulesDefinitionTest.java
Show resolved
Hide resolved
...red-library/src/main/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinition.java
Show resolved
Hide resolved
...red-library/src/main/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinition.java
Show resolved
Hide resolved
sonar-dotnet-shared-library/src/test/resources/AbstractRulesDefinitionTest/Rules.json
Show resolved
Hide resolved
sonar-dotnet-shared-library/src/test/resources/AbstractRulesDefinitionTest/S1115.json
Show resolved
Hide resolved
sonar-dotnet-shared-library/src/test/resources/AbstractRulesDefinitionTest/S1116.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one major concern about the standard name.
...red-library/src/main/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinition.java
Outdated
Show resolved
Hide resolved
...red-library/src/main/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinition.java
Show resolved
Hide resolved
...library/src/test/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinitionTest.java
Outdated
Show resolved
Hide resolved
...library/src/test/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinitionTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with assertion fixes
...library/src/test/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinitionTest.java
Outdated
Show resolved
Hide resolved
...library/src/test/java/org/sonarsource/dotnet/shared/plugins/AbstractRulesDefinitionTest.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
Fixes #5929