S1656: Add support for deconstruction #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned martin-strecker-sonarsource
| @@ -26,20 +26,21 @@ namespace SonarAnalyzer.UnitTest.Rules | |||
| [TestClass] | |||
| public class SelfAssignmentTest | |||
| { | |||
| private readonly VerifierBuilder builderCS= new VerifierBuilder<CS.SelfAssignment>(); | |||
| private readonly VerifierBuilder builderVB= new VerifierBuilder<VB.SelfAssignment>(); | |||
There was a problem hiding this comment.
code style: one more space is needed before the equals sign.
mary-georgiou-sonarsource
approved these changes
Jun 28, 2022
github-actions
bot
assigned martin-strecker-sonarsource and unassigned mary-georgiou-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
approved these changes
Jun 28, 2022
Comment on lines
47
to
48
| var assigments = expression.MapAssignmentArguments().Where(x => CSharpEquivalenceChecker.AreEquivalent(x.Left, x.Right)); | ||
| foreach (var assigment in assigments) |
There was a problem hiding this comment.
I wouldn't give it a name, it's single use. I'd put the linq inside foreach
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.