Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S6424: Azure Functions - Entity interfaces restrictions #5681

Merged
merged 14 commits into from
Jun 3, 2022
Merged

Rule S6424: Azure Functions - Entity interfaces restrictions #5681

merged 14 commits into from
Jun 3, 2022

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented May 31, 2022 •
edited
Loading

Fixes #5600

This part is not implemented, because we can't infer what entity class will be used.

  • Entity interfaces must be defined in the same assembly as the entity class.

martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jun 1, 2022
View reviewed changes
analyzers/src/SonarAnalyzer.CSharp/Rules/CloudNative/DurableEntityInterfaceRestrictions.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/CloudNative/DurableEntityInterfaceRestrictions.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/CloudNative/DurableEntityInterfaceRestrictions.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/CloudNative/DurableEntityInterfaceRestrictions.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/CloudNative/DurableEntityInterfaceRestrictions.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/CloudNative/DurableEntityInterfaceRestrictions.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/CloudNative/DurableEntityInterfaceRestrictions.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/CloudNative/DurableEntityInterfaceRestrictions.cs Show resolved Hide resolved
@martin-strecker-sonarsource
Copy link
Contributor

Fixes #5600

This part is not implemented, because we can't infer what entity class will be used.

  • Entity interfaces must be defined in the same assembly as the entity class.

Technically it would be possible to implement it: https://stackoverflow.com/a/64651150

@pavel-mikula-sonarsource
Copy link
Contributor Author

Fixes #5600
This part is not implemented, because we can't infer what entity class will be used.

  • Entity interfaces must be defined in the same assembly as the entity class.

Technically it would be possible to implement it: https://stackoverflow.com/a/64651150

We'd need to track what is the value inside EntityId object to get the proper entity name in case the same interface is implemented by more classes.

I'll just cut this branch because of a low ROI for a high investment.

martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One loophole seems to be left.

analyzers/src/SonarAnalyzer.CSharp/Rules/CloudNative/DurableEntityInterfaceRestrictions.cs Show resolved Hide resolved
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type parameter test case is missing.

...ers/tests/SonarAnalyzer.UnitTest/TestCases/CloudNative/DurableEntityInterfaceRestrictions.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/CloudNative/DurableEntityInterfaceRestrictions.cs Show resolved Hide resolved
martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-strecker-sonarsource
Copy link
Contributor

Approved, but I assigned you and put it in "In progress" because of merge conflicts.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 910af4d into master Jun 3, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/S6424-Interfaces branch June 3, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule S6424: Azure Functions - Entity interfaces restrictions
2 participants
@pavel-mikula-sonarsource @martin-strecker-sonarsource