Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S2436: Add support for record structs #5611

Merged
merged 24 commits into from
May 5, 2022
Merged

S2436: Add support for record structs #5611

merged 24 commits into from
May 5, 2022

Conversation

martin-strecker-sonarsource
Copy link
Contributor

No description provided.

@martin-strecker-sonarsource martin-strecker-sonarsource added this to the 8.39 milestone Apr 30, 2022
@martin-strecker-sonarsource
Copy link
Contributor Author

ITs are failing because of the changes made in 154c11a. If the change is ok, I will update the ITs.

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff

analyzers/src/SonarAnalyzer.Common/Helpers/EnumerableExtensions.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/EnumerableExtensions.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Extensions/SyntaxNodeExtensions.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Helpers/EnumerableExtensionsTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Helpers/EnumerableExtensionsTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/TooManyGenericParametersTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/TooManyGenericParametersTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/TooManyGenericParameters.CSharp10.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/TooManyGenericParameters.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/TooManyGenericParameters.cs Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few unresolved conversations above

analyzers/tests/SonarAnalyzer.UnitTest/Helpers/EnumerableExtensionsTest.cs Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to remove the namespace pain - see answer in the last unresolved thread

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit aa2e4c3 into master May 5, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Martin/RecordStruct_S2436 branch May 5, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
None yet
Projects
None yet
Milestone
8.39
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-strecker-sonarsource @pavel-mikula-sonarsource