S2743: Add support for record struct #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
martin-strecker-sonarsource
approved these changes
Apr 28, 2022
Comment on lines
48
to
49
| || typeDeclaration.TypeParameterList == null | ||
| || typeDeclaration.TypeParameterList.Parameters.Count < 1) |
There was a problem hiding this comment.
Suggested change
| || typeDeclaration.TypeParameterList == null | |
| || typeDeclaration.TypeParameterList.Parameters.Count < 1) | |
| || c.Node is not TypeDeclarationSyntax { TypeParameterList: { Parameters: { Count: > 0 } } } typeDeclaration) |
There was a problem hiding this comment.
@csaba-sagi-sonarsource That's one of the places where C#10 would remove some clutter:
// C# 9
c.Node is not TypeDeclarationSyntax { TypeParameterList: { Parameters: { Count: > 0 } } } typeDeclaration)
// C# 10
c.Node is not TypeDeclarationSyntax { TypeParameterList.Parameters.Count: > 0 } typeDeclaration)
Comment on lines
54
to
58
| var fields = typeDeclaration.Members.OfType<FieldDeclarationSyntax>().Where(x => x.Modifiers.Any(SyntaxKind.StaticKeyword)); | ||
| foreach (var field in fields.Where(x => !HasGenericType(c, x.Declaration.Type, typeParameterNames))) | ||
| { | ||
| field.Declaration.Variables.ToList().ForEach(variable => CheckMember(variable, variable.Identifier.GetLocation(), typeParameterNames, c)); | ||
| field.Declaration.Variables.ToList().ForEach(variable => CheckMember(c, variable, variable.Identifier.GetLocation(), typeParameterNames)); | ||
| } |
There was a problem hiding this comment.
Can be simplified:
var variables = typeDeclaration.Members
.OfType<FieldDeclarationSyntax>()
.Where(x => x.Modifiers.Any(SyntaxKind.StaticKeyword) && !HasGenericType(c, x.Declaration.Type, typeParameterNames))
.SelectMany(x => x.Declaration.Variables);
foreach (var variable in variables)
{
CheckMember(c, variable, variable.Identifier.GetLocation(), typeParameterNames);
}There was a problem hiding this comment.
Nice
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.