Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S4049: Add support for record struct #5593

Merged
merged 10 commits into from
May 3, 2022
Merged

S4049: Add support for record struct #5593

merged 10 commits into from
May 3, 2022

Conversation

martin-strecker-sonarsource
Copy link
Contributor

No description provided.

@martin-strecker-sonarsource martin-strecker-sonarsource added this to the 8.39 milestone Apr 25, 2022
@martin-strecker-sonarsource martin-strecker-sonarsource removed their assignment Apr 25, 2022
@martin-strecker-sonarsource
Copy link
Contributor Author

Some ITs are failing because of the addition of structs, but they are all true positives.

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one line to revert before merging

analyzers/src/SonarAnalyzer.CFG/Helpers/StringExtensions.cs Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource merged commit 1cd0d84 into master May 3, 2022
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Martin/RecordStruct_S4049 branch May 3, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
None yet
Projects
None yet
Milestone
8.39
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-strecker-sonarsource @pavel-mikula-sonarsource