S3903: Add support for record structs #5574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analyzers/src/SonarAnalyzer.Common/Rules/DeclareTypesInNamespacesBase.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
| @@ -43,8 +42,7 @@ public abstract class DeclareTypesInNamespacesBase<TSyntaxKind> : SonarDiagnosti | |||
| c => | |||
| { | |||
| var declaration = c.Node; | |||
|
|
|||
| if (c.ContainingSymbol.Kind != SymbolKind.NamedType | |||
| if (c.IsRedundantPositionalRecordContext() | |||
There was a problem hiding this comment.
Optional: There are just 2 conditions that are simple and have explicit name. It can be on a single ine.
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR as part of the
record structsaga. It contains a move of theSyntaxNodeAnalysisContextExtensions.csfile which may introduce conflicts with the otherrecord structPRs.