Fix S2187 FP: Support test attributes deriving from ITestBuilder in NUnit
#5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NUnit3 added support for custom test attributes via the ITestBuilder interface. The analyzer for S2187 would not consider test methods decorated with such attributes, giving a false positive result if the fixture only contained such methods. Because this interface only exists in NUnit3, tests for it are split into a separate file, so that analyzer tests can be executed only for NUnit version 3.0.0 and up.
pavel-mikula-sonarsource
requested changes
Apr 19, 2022
There was a problem hiding this comment.
Hi @dammejed, thank you for giving this a try.
I left a few nitpicks in the test refactoring to address. And I expect one of the UTs to fail due to a missing line.
analyzers/tests/SonarAnalyzer.UnitTest/Rules/TestClassShouldHaveTestMethodTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/TestClassShouldHaveTestMethodTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/TestClassShouldHaveTestMethodTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/TestClassShouldHaveTestMethodTest.cs
Outdated
Show resolved
Hide resolved
|
/azp run Sonar.Net.External |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dammejed
force-pushed
the
S2187-FP
branch
2 times, most recently
from
1d06c36 to
a8ed90b
Compare
|
I made the changes-- sorry for the sloppiness with the unit test! |
No worries. It was actually pretty good. |
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
SonarCloud Quality Gate failed. |
|
Kudos, SonarCloud Quality Gate passed!
|
pavel-mikula-sonarsource
changed the title
ITestBuilder in NUnit
|
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5564