Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Visual Basic unit tests #5550

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Add Visual Basic unit tests #5550

merged 3 commits into from
Apr 8, 2022

Conversation

costin-zaharia-sonarsource
Copy link
Member

Related to #4220

@costin-zaharia-sonarsource costin-zaharia-sonarsource linked an issue Apr 7, 2022 that may be closed by this pull request
Reduce the number of symbols retrieved by SymbolReferenceAnalyzer #4220
Closed
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just one comment in the Property.vb that is important. The rest are just nitpicks.

analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/Event.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/Event.vb Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/Function.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/Function.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/NamedType.vb Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/NamedType.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/Parameter.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/NamedType.vb Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/Property.vb Outdated Show resolved Hide resolved
...rs/tests/SonarAnalyzer.UnitTest/TestCases/Utilities/SymbolReferenceAnalyzer/TypeParameter.vb Outdated Show resolved Hide resolved
csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If Pavel (VB.NET) Mikula does not find anything it can be merged.

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment to address (in one or other way)

analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/SymbolReferenceAnalyzerTest.cs Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 3c73826 into master Apr 8, 2022
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costin/sra-vb-tests branch April 8, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@costin-zaharia-sonarsource costin-zaharia-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce the number of symbols retrieved by SymbolReferenceAnalyzer
3 participants
@costin-zaharia-sonarsource @pavel-mikula-sonarsource @csaba-sagi-sonarsource