Improve performance for SymbolReferenceAnalyzer #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [DataTestMethod] | ||
| [DataRow(true)] | ||
| [DataRow(false)] | ||
| public void GetSetKeyword_ReturnsNull_VB(bool isTestProject) => |
There was a problem hiding this comment.
"set" keyword was supported only for adding support for "value". This complicated the logic and it was not consistent. The "set" declaration was added only in the presence of "value".
I prefer to remove this part of the functionality and keep the logic simple.
| @@ -101,7 +101,7 @@ public class SymbolReferenceAnalyzerTest | |||
| [DataRow(ProjectType.Product)] | |||
| [DataRow(ProjectType.Test)] | |||
| public void Verify_NamedType_CS(ProjectType projectType) => | |||
| Verify("NamedType.cs", projectType, 4, 3, 7, 7); // 'var' and type name on the same line | |||
There was a problem hiding this comment.
"var" here was redirecting to the underlying type, which was nice. I've dropped the support, for now, to keep the logic simple but I might change my mind until if finish with this rework.
costin-zaharia-sonarsource
force-pushed
the
costin/SymbolReference-perf-opt
branch
7 times, most recently
from
30179bf to
f2b464a
Compare
costin-zaharia-sonarsource
changed the base branch from
master
to
costin/sra-vb-tests
costin-zaharia-sonarsource
force-pushed
the
costin/SymbolReference-perf-opt
branch
4 times, most recently
from
1d93ac6 to
0578574
Compare
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned costin-zaharia-sonarsource
analyzers/src/SonarAnalyzer.Common/Rules/Utilities/SymbolReferenceAnalyzerBase.cs
Show resolved
Hide resolved
costin-zaharia-sonarsource
force-pushed
the
costin/SymbolReference-perf-opt
branch
from
0578574 to
da188ec
Compare
analyzers/src/SonarAnalyzer.Common/Rules/Utilities/SymbolReferenceAnalyzerBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/Utilities/SymbolReferenceAnalyzerBase.cs
Outdated
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Apr 8, 2022
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned csaba-sagi-sonarsource
costin-zaharia-sonarsource
requested review from
csaba-sagi-sonarsource and
pavel-mikula-sonarsource
|
I've dismissed myself from the reviewers, I'm just a kibitzer here. My threads are resolved now 🎉 |
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned costin-zaharia-sonarsource
costin-zaharia-sonarsource
force-pushed
the
costin/SymbolReference-perf-opt
branch
from
03fd471 to
bd51ce7
Compare
analyzers/src/SonarAnalyzer.Common/Rules/Utilities/SymbolReferenceAnalyzerBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/Utilities/SymbolReferenceAnalyzerBase.cs
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Apr 12, 2022
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned csaba-sagi-sonarsource
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned costin-zaharia-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned csaba-sagi-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the analyzer to work as much as possible at the syntax level by retrieving symbols only when strictly necessary.
Tested this rule on:
Part of #4220