FIX S2252 FP: Rule raises issue in case of non integer value in for loop. #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costin-zaharia-sonarsource
requested changes
Mar 30, 2022
analyzers/src/SonarAnalyzer.CSharp/Rules/ForLoopConditionAlwaysFalse.cs
Outdated
Show resolved
Hide resolved
| { | ||
| var loopInitializerValues = new Dictionary<string, int>(); | ||
| var loopInitializerValues = new Dictionary<string, double>(); | ||
| if (variableDeclarationSyntax != null) | ||
| { | ||
| foreach (var variableDeclaration in variableDeclarationSyntax.Variables) | ||
| { | ||
| if (variableDeclaration.Initializer is EqualsValueClauseSyntax initializer |
There was a problem hiding this comment.
We can simplify this to if (variableDeclaration.Initializer is { } initializer
Comment on lines
176
to
177
| && initializer is AssignmentExpressionSyntax assignment | ||
| && assignment.Left is SimpleNameSyntax simpleName |
There was a problem hiding this comment.
pedantic: we can use pattern matching and simplify this a bit:
&& initializer is AssignmentExpressionSyntax { Left: SimpleNameSyntax simpleName } assignment
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ForLoopConditionAlwaysFalse.cs
Show resolved
Hide resolved
csaba-sagi-sonarsource
force-pushed
the
čaba/S2252
branch
from
64beaf6 to
bef9c9e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5428