Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S2222 to SonarWay profile #5508

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Add S2222 to SonarWay profile #5508

merged 2 commits into from
Mar 28, 2022

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Mar 25, 2022 •
edited
Loading

Fixes #5310, 2nd attempt

Applies changes from SonarSource/rspec#831

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as draft March 25, 2022 12:35
csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review March 25, 2022 15:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as draft March 25, 2022 17:10
@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review March 28, 2022 20:45
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 1e29780 into master Mar 28, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/SonarWay branch March 28, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add S2222 to SonarWay profile
2 participants
@pavel-mikula-sonarsource @csaba-sagi-sonarsource