Support BinaryOperation for Boolean expressions in SE

[pavel-mikula-sonarsource]

Fixes #5478

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[csaba-sagi-sonarsource]

LGTM! We should also add support for unary operators. Negation is used a lot and would be nice to support. Most probably in a separate PR. Will you open an issue for it?

[pavel-mikula-sonarsource]

Negation on booleans does not translate to unary operation, it is already supported by supporting the property CFG shape, see

sonar-dotnet/analyzers/tests/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Branching.cs

Lines 319 to 336 in ab6dfa0

	[TestMethod]
	public void Branching_TrueConstraintNegated_VisitsElseBranch()
	{
	const string code = @"
	var value = true;
	if (!value)
	{
	Tag(""If"");
	}
	else
	{
	Tag(""Else"");
	}
	Tag(""End"");";
	SETestContext.CreateCS(code).Validator.ValidateTagOrder(
	"Else",
	"End");
	}

sonar-dotnet/analyzers/tests/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Branching.cs

Lines 357 to 374 in ab6dfa0

	[TestMethod]
	public void Branching_FalseConstraintNegated_VisitsIfBranch()
	{
	const string code = @"
	var value = false;
	if (!value)
	{
	Tag(""If"");
	}
	else
	{
	Tag(""Else"");
	}
	Tag(""End"");";
	SETestContext.CreateCS(code).Validator.ValidateTagOrder(
	"If",
	"End");
	}

and complex case

sonar-dotnet/analyzers/tests/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Branching.cs

Lines 416 to 445 in ab6dfa0

	[TestMethod]
	public void Branching_BoolConstraints_ComplexCase()
	{
	const string code = @"
	var isTrue = true;
	var isFalse = false;
	if (isTrue && isTrue && !isFalse)
	{
	if (isFalse || !isTrue)
	{
	Tag(""UnreachableIf"");
	}
	else if (isFalse)
	{
	Tag(""UnreachableElseIf"");
	}
	else
	{
	Tag(""Reachable"");
	}
	}
	else
	{
	Tag(""UnreachableElse"");
	}
	Tag(""End"");";
	SETestContext.CreateCS(code).Validator.ValidateTagOrder(
	"Reachable",
	"End");
	}

[csaba-sagi-sonarsource]

@pavel-mikula-sonarsource I did not provide an example, my bad...
I tried the following example, which did not work:

var isTrue = true;
var isFalse = false;

if (isTrue == !isFalse)
    Tag(""True"");
else
    Tag(""True Unreachable"");

[pavel-mikula-sonarsource]

MMF-2563 will be a good place to do stuff like this

[Tim-Pohlmann]

The example above works now. It got implemented during an earlier MMF.