Support conditional branching in SE #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...sts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Branching.cs
Outdated
Show resolved
Hide resolved
...sts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Branching.cs
Outdated
Show resolved
Hide resolved
...sts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Branching.cs
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Mar 10, 2022
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE-ConditionalBranching
branch
from
f973229 to
19f640b
Compare
...sts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Branching.cs
Show resolved
Hide resolved
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE-ConditionalBranching
branch
from
987cbcd to
549884c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
| Tag(""End"");"; | ||
| SETestContext.CreateCS(code).Validator.ValidateTagOrder( | ||
| "True", | ||
| "False", // This should not be here, switch statement produces BinaryOperatin with isTrue==true |
There was a problem hiding this comment.
Will you open an issue for this?
There was a problem hiding this comment.
No, there's MMF-2563 for it
There was a problem hiding this comment.
And I might create a small PR for simple support
| false => false | ||
| }; | ||
| Tag(""Value"", value);"; | ||
| SETestContext.CreateCS(code).Validator.ValidateTag("Value", x => x.Should().BeNull()); // Should have BoolConstraint.True instead |
There was a problem hiding this comment.
Same here, do you plane to open an issue for this?
There was a problem hiding this comment.
No, there's MMF-2229 for it.
csaba-sagi-sonarsource
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5308