Cache CreateCfg #5403
Cache CreateCfg #5403
Conversation
pavel-mikula-sonarsource
force-pushed
the
Pavel/CfgCache
branch
from
e7f17d2 to
13988af
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
|
|
||
| public ControlFlowGraph FindOrCreate(SyntaxNode declaration, SemanticModel model) | ||
| { | ||
| var rootSyntax = model.GetOperation(declaration).RootOperation().Syntax; |
There was a problem hiding this comment.
I'm not sure I understand how this is meant to work. If we take the example from CreateCfg_Performance_UsesCache_CS and we request the CFG for the lambda, we will receive the CFG of the root operation this is the method declaration. Is this right?
There was a problem hiding this comment.
Yes, exactly. Roslyn doesn't let us directly create CFG for Lambda/Local function. We need to create a CFG from the root (method). And find our desired CFG in the CFG tree.
That's also the reason for the high cache hit rate.
| SyntaxNodeExtensionsCS.CreateCfg(lambda, model); | ||
| } | ||
| }; | ||
| a.ExecutionTime().Should().BeLessThan(1.Seconds()); // Takes roughly 0.2 sec on CI |
There was a problem hiding this comment.
Have you tried to run without the cache? I'm curious about the improvement.
There was a problem hiding this comment.
Roughly 5x slower on my machine without cache on this very small method. The bigger the method is, the worse it gets.
I used the full user repro project build to see how it works. It went down from 8 minutes to 20 sec with the cache.
Fixes #5384
When analyzing user project with only S1854 active, I get 20 sec build&analysis time after this change.
For 16000 invocations on that project, we have 11086 cache hits and 4914 cache misses.